chrome/browser/policy/configuration_policy_handler.cc - Issue 8413037: Display policy parsing errors in about:policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_handler.cc

Issue 8413037: Display policy parsing errors in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/configuration_policy_handler.cc

diff --git a/chrome/browser/policy/configuration_policy_handler.cc b/chrome/browser/policy/configuration_policy_handler.cc

index 38f9e69bab074dcd714408887a6ba230617d5eee..dea0239829e8a804aa20cd91df3e5d37da2fcc18 100644

--- a/chrome/browser/policy/configuration_policy_handler.cc

+++ b/chrome/browser/policy/configuration_policy_handler.cc

@@ -1027,9 +1027,9 @@ bool ProxyPolicyHandler::CheckPolicySettings(const PolicyMap* policies,

if (!entry.pac_url_allowed && pac_url)

errors->AddError(kPolicyProxyPacUrl, entry.error_message_id);

if (!entry.bypass_list_allowed && bypass_list)

- errors->AddError(kPolicyProxyPacUrl, entry.error_message_id);

+ errors->AddError(kPolicyProxyBypassList, entry.error_message_id);

Mattias Nissler (ping if slow) 2011/10/28 15:18:51 good catch!

if (!entry.server_allowed && server)

- errors->AddError(kPolicyProxyPacUrl, entry.error_message_id);

+ errors->AddError(kPolicyProxyServer, entry.error_message_id);

if ((!entry.pac_url_allowed && pac_url) ||

(!entry.bypass_list_allowed && bypass_list) ||