Chromium Code Reviews| Index: client/fling/src/java/core/com/google/dart/CompileService.java |
| =================================================================== |
| --- client/fling/src/java/core/com/google/dart/CompileService.java (revision 881) |
| +++ client/fling/src/java/core/com/google/dart/CompileService.java (working copy) |
| @@ -131,16 +131,18 @@ |
| private final List<CompileError> warnings = Lists.newArrayList(); |
| @Override |
| + public void onError(DartCompilationError error) { |
| + fatalErrors.add(CompileError.from(error)); |
| + } |
| + |
| public void compilationError(DartCompilationError error) { |
|
ngeoffray
2011/10/28 11:00:29
I think the three following methods should go away
|
| fatalErrors.add(CompileError.from(error)); |
| } |
| - @Override |
| public void compilationWarning(DartCompilationError error) { |
| warnings.add(CompileError.from(error)); |
| } |
| - @Override |
| public void typeError(DartCompilationError error) { |
| typeErrors.add(CompileError.from(error)); |
| } |
| @@ -193,20 +195,11 @@ |
| snapshot, |
| new DartCompilerListener() { |
| @Override |
| - public void compilationError(DartCompilationError error) { |
| + public void onError(DartCompilationError error) { |
| throw new RuntimeException("Unable to build runtime lib: " + error); |
| } |
| @Override |
| - public void compilationWarning(DartCompilationError warning) { |
| - } |
| - |
| - @Override |
| - public void typeError(DartCompilationError error) { |
| - throw new RuntimeException("Unable to build runtime lib: " + error); |
| - } |
| - |
| - @Override |
| public void unitCompiled(DartUnit unit) { |
| } |
| }); |