Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: client/fling/src/java/core/com/google/dart/CompileService.java

Issue 8413033: Unbreak the build. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/fling/src/java/core/com/google/dart/CompileService.java
===================================================================
--- client/fling/src/java/core/com/google/dart/CompileService.java (revision 881)
+++ client/fling/src/java/core/com/google/dart/CompileService.java (working copy)
@@ -131,16 +131,18 @@
private final List<CompileError> warnings = Lists.newArrayList();
@Override
+ public void onError(DartCompilationError error) {
+ fatalErrors.add(CompileError.from(error));
+ }
+
public void compilationError(DartCompilationError error) {
ngeoffray 2011/10/28 11:00:29 I think the three following methods should go away
fatalErrors.add(CompileError.from(error));
}
- @Override
public void compilationWarning(DartCompilationError error) {
warnings.add(CompileError.from(error));
}
- @Override
public void typeError(DartCompilationError error) {
typeErrors.add(CompileError.from(error));
}
@@ -193,20 +195,11 @@
snapshot,
new DartCompilerListener() {
@Override
- public void compilationError(DartCompilationError error) {
+ public void onError(DartCompilationError error) {
throw new RuntimeException("Unable to build runtime lib: " + error);
}
@Override
- public void compilationWarning(DartCompilationError warning) {
- }
-
- @Override
- public void typeError(DartCompilationError error) {
- throw new RuntimeException("Unable to build runtime lib: " + error);
- }
-
- @Override
public void unitCompiled(DartUnit unit) {
}
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698