Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 8413026: Add pyauto-based perf test for the SunSpider benchmark suite. (Closed)

Created:
9 years, 1 month ago by dennis_jeffrey
Modified:
9 years, 1 month ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey, Sonny, chrisphan
Visibility:
Public.

Description

Add pyauto-based perf test for the SunSpider benchmark suite. BUG=chromium-os:18457 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107834

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed reviewer comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M chrome/test/functional/perf.py View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dennis_jeffrey
9 years, 1 month ago (2011-10-28 02:04:57 UTC) #1
Nirnimesh
LGTM http://codereview.chromium.org/8413026/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8413026/diff/1/chrome/test/functional/perf.py#newcode290 chrome/test/functional/perf.py:290: total = re.search(total_pattern, results).group(1) merge with previous line ...
9 years, 1 month ago (2011-10-28 07:36:49 UTC) #2
dennis_jeffrey
Thank you for the review. Now marking this as commit-ready. http://codereview.chromium.org/8413026/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8413026/diff/1/chrome/test/functional/perf.py#newcode290 ...
9 years, 1 month ago (2011-10-28 22:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/8413026/3001
9 years, 1 month ago (2011-10-28 22:29:55 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-29 00:46:33 UTC) #5
Change committed as 107834

Powered by Google App Engine
This is Rietveld 408576698