Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 8413023: Remove --no-startup-window flag when restarting chrome. (Closed)

Created:
9 years, 1 month ago by Andrew T Wilson (Slow)
Modified:
9 years, 1 month ago
Reviewers:
Rick Campbell
CC:
chromium-reviews
Visibility:
Public.

Description

Remove --no-startup-window flag when restarting chrome. This fixes the problem where if chrome launches in background mode at login, the next time we restart chrome we relaunch it in background mode again. BUG=92391 TEST=Install background app, restart computer so chrome is launched on startup, go to about:flags and change a flag and choose 'Restart' - chrome should reopen any open windows on restart. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107763

Patch Set 1 #

Patch Set 2 : Also remove kRestoreLastSession on restart so it does not persist. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/switch_utils.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Andrew T Wilson (Slow)
9 years, 1 month ago (2011-10-28 01:15:07 UTC) #1
Rick Campbell
LGTM
9 years, 1 month ago (2011-10-28 15:08:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/8413023/2001
9 years, 1 month ago (2011-10-28 16:43:49 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 18:39:23 UTC) #4
Change committed as 107763

Powered by Google App Engine
This is Rietveld 408576698