Issue 8413015: Add some error checking to CMDpassthru for invalid arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8413015: Add some error checking to CMDpassthru for invalid arguments. (Closed)

Created:
9 years, 1 month ago by SteveT

Modified:
9 years, 1 month ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Add some error checking to CMDpassthru for invalid arguments. TEST=Run a passthru command like gcl di or gcl revert without a changelist name. Ensure that gcl exits with an error message. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107663

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	gcl.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/8413015/1

9 years, 1 month ago (2011-10-28 00:19:29 UTC) #3

Change committed as 107663

Expand Messages | Collapse Messages