Issue 8412009: Turn on content-security-policy for chrome://syncpromo webui page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8412009: Turn on content-security-policy for chrome://syncpromo webui page. (Closed)

Created:
9 years, 1 month ago by Tom Sepez

Modified:
9 years, 1 month ago

Reviewers:
abarth-chromium, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Turn on content-security-policy for chrome://syncpromo webui page. This recent page was nearly in the correct form as-is, but needed a small number of changes about how it includes script resources before it could be removed from the list of excluded entryponts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108944

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -13 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/sync_promo.html	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/resources/sync_promo.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_url_data_manager_backend.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tom Sepez

Found this one today as linked from NTP in m16 beta. Please review.

9 years, 1 month ago (2011-11-03 22:29:00 UTC) #1

lgtm

Expand Messages | Collapse Messages