Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 8411001: Fix generation of API documentation for arrays of objects (Closed)

Created:
9 years, 1 month ago by battre
Modified:
9 years, 1 month ago
Reviewers:
Matt Perry, rafaelw
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Fix generation of API documentation for arrays of objects If a type reflects an array of objects with specified properties, such as here "id": "HttpHeaders", "type": "array", "items": { "type": "object", "properties": {...} }, the API documentation generator would swallow the contents of "properties". The documentation would just contain the information that an array of objects is passed, without details of the keys stored in the objects. This is fixed in this CL. BUG=no TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -9 lines) Patch
M chrome/common/extensions/api/extension_api.json View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/experimental.webRequest.html View 2 chunks +134 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/extension.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/webNavigation.html View 2 chunks +201 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
battre
rafaelw for chrome/common/extensions/docs/js/api_page_generator.js mpcomplete for chrome/common/extensions/api/extension_api.json Rafael, the change in extension_api.json shows an example where ...
9 years, 1 month ago (2011-10-27 17:00:57 UTC) #1
Matt Perry
lgtm
9 years, 1 month ago (2011-10-27 18:42:26 UTC) #2
rafaelw
lgtm
9 years, 1 month ago (2011-10-27 18:43:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8411001/1
9 years, 1 month ago (2011-10-27 18:52:36 UTC) #4
commit-bot: I haz the power
Try job failure for 8411001-1 (previous was lost) (retry) on linux_rel for step "ui_tests". It's ...
9 years, 1 month ago (2011-10-27 21:35:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8411001/1
9 years, 1 month ago (2011-10-28 08:34:29 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 09:36:50 UTC) #7
Change committed as 107704

Powered by Google App Engine
This is Rietveld 408576698