Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: breakpad/breakpad.gyp

Issue 8409009: Make dump_syms 64-bit on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
===================================================================
--- breakpad/breakpad.gyp (revision 107940)
+++ breakpad/breakpad.gyp (working copy)
@@ -106,12 +106,6 @@
{
'target_name': 'dump_syms',
'type': 'executable',
- 'variables': {
- # Turn off PIE because it may interfere with dump_syms' ability to
- # allocate a contiguous region in memory large enough to mmap the
- # entire unstripped framework in a 32-bit dump_syms process.
- 'mac_pie': 0,
- },
'include_dirs++': [
# ++ ensures this comes before src brought in from target_defaults.
'pending/src',
@@ -144,8 +138,17 @@
'HAVE_MACH_O_NLIST_H',
],
'xcode_settings': {
+ # Like ld, dump_syms needs to operate on enough data that it may
+ # actually need to be able to address more than 4GB. Use x86_64.
+ # Don't worry! An x86_64 dump_syms is perfectly able to dump
+ # 32-bit files.
+ 'ARCHS': [
+ 'x86_64',
+ ],
+
# The DWARF utilities require -funsigned-char.
'GCC_CHAR_IS_UNSIGNED_CHAR': 'YES',
+
# dwarf2reader.cc uses dynamic_cast.
'GCC_ENABLE_CPP_RTTI': 'YES',
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698