Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 8409009: Make dump_syms 64-bit on Mac (Closed)

Created:
9 years, 1 month ago by Mark Mentovai
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Make dump_syms 64-bit on Mac. The framework's grown to the point that 32-bit dump_syms no longer has enough memory to do its job. It is failing with messages like: dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug dump_syms(12345) malloc: *** mmap(size=2097152) failed (error code=12) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug terminate called after throwing an instance of 'St9bad_alloc' what(): std::bad_alloc Moving to 64-bit gives it more space to work with. 64-bit dump_syms is able to dump 32-bit files. BUG=102361 TEST=Breakpad-enabled official release builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M breakpad/breakpad.gyp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
9 years, 1 month ago (2011-10-31 14:03:36 UTC) #1
Nico
9 years, 1 month ago (2011-10-31 14:06:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698