Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1324)

Unified Diff: dart/tests/stub-generator/testcfg.py

Issue 8408002: Add a new variable environment for testing, to replace the misusage of 'arch'. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/stub-generator/testcfg.py
===================================================================
--- dart/tests/stub-generator/testcfg.py (revision 952)
+++ dart/tests/stub-generator/testcfg.py (working copy)
@@ -18,11 +18,13 @@
return re.sub('\.dart$', '-generatedTest.dart', src)
class DartStubTestCase(test_case.StandardTestCase):
- def __init__(self, context, path, filename, mode, arch):
- super(DartStubTestCase, self).__init__(context, path, filename, mode, arch)
+ def __init__(self, context, path, filename, mode, arch, FOOBAR):
+ super(DartStubTestCase, self).__init__(context, path, filename, mode, arch,
+ FOOBAR)
self.filename = filename
self.mode = mode
self.arch = arch
+ self.FOOBAR = FOOBAR
def IsBatchable(self):
return False
@@ -86,7 +88,7 @@
(interface, _, implementation) = self.GetStubs()
# Combine everything into a command array and return it.
- command = self.context.GetDart(self.mode, self.arch)
+ command = self.context.GetDart(self.mode, self.arch, self.FOOBAR)
if interface is None:
f = self.filename
else:
@@ -102,7 +104,7 @@
def __init__(self, context, root):
super(DartStubTestConfiguration, self).__init__(context, root)
- def ListTests(self, current_path, path, mode, arch):
+ def ListTests(self, current_path, path, mode, arch, FOOBAR):
dartc = self.context.GetDartC(mode, 'dartc')
self.context.generate = os.access(dartc[0], os.X_OK)
tests = []
@@ -124,7 +126,8 @@
test_path,
join(root, f),
mode,
- arch))
+ arch,
+ FOOBAR))
return tests

Powered by Google App Engine
This is Rietveld 408576698