Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2560)

Unified Diff: dart/tests/language/language.status

Issue 8408002: Add a new variable environment for testing, to replace the misusage of 'arch'. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/isolate/isolate.status ('k') | dart/tests/standalone/standalone.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/language/language.status
===================================================================
--- dart/tests/language/language.status (revision 991)
+++ dart/tests/language/language.status (working copy)
@@ -17,7 +17,7 @@
prefix language
-[ $arch == ia32 || $arch == dartium ]
+[ $component == vm || $component == dartium ]
ClassTest: Fail # Bug 4504458 (pseudo keyword)
NamingTest: Fail # Bug 4504458 (pseudo keyword)
SuperTest: Fail # Bug 4995181
@@ -50,11 +50,11 @@
# DartC specific tests that should not be run by the VM.
*DartcTest: Skip
-[ $arch == ia32 && $mode == debug ]
+[ $component == vm && $mode == debug ]
NonParameterizedFactoryTest: Crash # Issue 226
# Problems specific to dartc optimized mode
-[ ($arch == dartc || $arch == chromium) && $mode == release ]
+[ ($component == dartc || $component == chromium) && $mode == release ]
MethodInvocationTest: Fail # Bug 5392266
Label2NegativeTest: Crash # Bug 5318228
NullPointerExceptionTest: Fail # Bug 5391976
@@ -65,10 +65,10 @@
CTConst2Test: Fail # Codesite issue 124
# Problems specific to dartc debug mode
-[ ($arch == dartc || $arch == chromium) && $mode == debug ]
+[ ($component == dartc || $component == chromium) && $mode == debug ]
-[ $arch == dartc || $arch == chromium ]
+[ $component == dartc || $component == chromium ]
Library4NegativeTest: Fail # Bug 5406175
Prefix3NegativeTest: Fail # Bug 5406175
Prefix11NegativeTest: Fail # Bug 5406175
@@ -164,7 +164,7 @@
*VMTest: Skip
-[ $arch == dartium ]
+[ $component == dartium ]
# TODO: These need to be retriaged.
ExpectTest: Fail
StackTraceTest: Fail
« no previous file with comments | « dart/tests/isolate/isolate.status ('k') | dart/tests/standalone/standalone.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698