Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2058)

Unified Diff: dart/tests/co19/testcfg.py

Issue 8408002: Add a new variable environment for testing, to replace the misusage of 'arch'. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/co19/testcfg.py
===================================================================
--- dart/tests/co19/testcfg.py (revision 991)
+++ dart/tests/co19/testcfg.py (working copy)
@@ -1,5 +1,5 @@
# Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
-# for details. All rights reserved. Use of this source code is governed by a
+# for details. All rights reserved. Use of this source code is governed by a
# BSD-style license that can be found in the LICENSE file.
@@ -16,17 +16,18 @@
class Co19TestCase(test.TestCase):
- def __init__(self, path, context, filename, mode, arch):
+ def __init__(self, path, context, filename, mode, arch, component):
super(Co19TestCase, self).__init__(context, path)
self.filename = filename
self.mode = mode
self.arch = arch
+ self.component = component
self._is_negative = None
def IsNegative(self):
if self._is_negative is None :
contents = self.GetSource()
- for tag in ('@compile-error','@static-type-error',
+ for tag in ('@compile-error','@static-type-error',
'@dynamic-type-error', '@runtime-error'):
if tag in contents:
self._is_negative = True
@@ -37,7 +38,7 @@
return self._is_negative
def GetLabel(self):
- return "%s%s %s" % (self.mode, self.arch, "/".join(self.path))
+ return "%s%s %s %s" % (self.mode, self.arch, self.component, "/".join(self.path))
def GetCommand(self):
# Parse the options by reading the .dart source file.
@@ -48,7 +49,7 @@
self.context.workspace)
# Combine everything into a command array and return it.
- command = self.context.GetDart(self.mode, self.arch)
+ command = self.context.GetDart(self.mode, self.arch, self.component)
command += self.context.flags
if self.mode == 'release': command += ['--optimize']
if vm_options: command += vm_options
@@ -71,7 +72,7 @@
def __init__(self, context, root):
super(Co19TestConfiguration, self).__init__(context, root)
- def ListTests(self, current_path, path, mode, arch):
+ def ListTests(self, current_path, path, mode, arch, component):
tests = []
src_dir = join(self.root, "src")
strip = len(src_dir.split(os.path.sep))
@@ -92,16 +93,16 @@
# remove suffixes
if short_name.endswith(".dart"):
short_name = short_name[:-5] # Remove .dart suffix.
- # now .app suffix discarded at self.IsTest()
+ # now .app suffix discarded at self.IsTest()
#elif short_name.endswith(".app"):
# short_name = short_name[:-4] # Remove .app suffix.
else:
raise Error('Unknown suffix in "%s", fix IsTest() predicate' % f)
-
+
while short_name.startswith('_'):
short_name = short_name[1:]
-
+
test_path.extend(short_name.split('_'))
# test full name and shorted name matches given path pattern
@@ -109,12 +110,13 @@
elif self.Contains(path, test_path + [test_name]): pass
else:
continue
-
+
tests.append(Co19TestCase(test_path,
self.context,
join(root, f),
mode,
- arch))
+ arch,
+ component))
return tests
_TESTNAME_PATTERN = re.compile(r'.*_t[0-9]{2}\.dart$')
@@ -132,7 +134,7 @@
def Contains(self, path, file):
""" reimplemented for support '**' glob pattern """
if len(path) > len(file):
- return
+ return
# ** matches to any number of directories, a/**/d matches a/b/c/d
# paths like a/**/x/**/b not allowed
patterns = [p.pattern for p in path]
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698