Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: dart/runtime/tests/vm/testcfg.py

Issue 8408002: Add a new variable environment for testing, to replace the misusage of 'arch'. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/compiler/tests/dartc/testcfg.py ('k') | dart/samples/tests/samples/samples.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/runtime/tests/vm/testcfg.py
===================================================================
--- dart/runtime/tests/vm/testcfg.py (revision 991)
+++ dart/runtime/tests/vm/testcfg.py (working copy)
@@ -21,9 +21,7 @@
return False
def GetLabel(self):
- return "%s %s" % (
- self.context.GetBuildConf(self.mode, self.arch),
- '/'.join(self.path))
+ return '%s%s vm %s' % (self.mode, self.arch, '/'.join(self.path))
def GetCommand(self):
command = self.context.GetRunTests(self.mode, self.arch)
@@ -42,9 +40,8 @@
def __init__(self, context, root):
super(VmTestConfiguration, self).__init__(context, root)
- def ListTests(self, current_path, path, mode, arch):
- if not arch in ['ia32', 'x64', 'arm', 'simarm']:
- return []
+ def ListTests(self, current_path, path, mode, arch, component):
+ if component != 'vm': return []
run_tests = self.context.GetRunTests(mode, arch)
output = test_runner.Execute(run_tests + ['--list'], self.context)
if output.exit_code != 0:
« no previous file with comments | « dart/compiler/tests/dartc/testcfg.py ('k') | dart/samples/tests/samples/samples.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698