chrome/browser/ui/views/toolbar_view.cc - Issue 8405002: ui/gfx: Convert Canvas::FillRectInt() to use gfx::Rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 8405002: ui/gfx: Convert Canvas::FillRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: save some vertical space, interactive_ui_tests are fixed by Peter's fix Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc

index 74875d1f1b28f16eccbb73fbe9ad5a25fc7bdd47..c792bb1ff5efb3945b7f291c02a8512f92e1e2fb 100644

--- a/chrome/browser/ui/views/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar_view.cc

@@ -594,7 +594,7 @@ void ToolbarView::OnPaint(gfx::Canvas* canvas) {

// toolbar background below the location bar for us.

// NOTE: Keep this in sync with BrowserView::GetInfoBarSeparatorColor()!

if (GetWidget()->ShouldUseNativeFrame())

- canvas->FillRectInt(SK_ColorBLACK, 0, height() - 1, width(), 1);

+ canvas->FillRect(SK_ColorBLACK, gfx::Rect(0, height() - 1, width(), 1));

}

// Note this method is ignored on Windows, but needs to be implemented for