Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: views/window/dialog_client_view.cc

Issue 8405002: ui/gfx: Convert Canvas::FillRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« views/window/custom_frame_view.cc ('K') | « views/window/custom_frame_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/window/dialog_client_view.cc
diff --git a/views/window/dialog_client_view.cc b/views/window/dialog_client_view.cc
index 9a75fe2587d12fd11533046583ac29b4a45bff75..b350ddcf1c659caf8757872ee03a2fba98646a2a 100644
--- a/views/window/dialog_client_view.cc
+++ b/views/window/dialog_client_view.cc
@@ -56,7 +56,7 @@ void UpdateButtonHelper(NativeTextButton* button_view,
void FillViewWithSysColor(gfx::Canvas* canvas, View* view, COLORREF color) {
SkColor sk_color =
SkColorSetRGB(GetRValue(color), GetGValue(color), GetBValue(color));
- canvas->FillRectInt(sk_color, 0, 0, view->width(), view->height());
+ canvas->FillRect(sk_color, gfx::Rect(gfx::Point(), view->size()));
Peter Kasting 2011/10/27 19:17:29 Nit: view->GetLocalBounds()
tfarina 2011/10/27 20:46:03 Done.
}
#endif
@@ -317,14 +317,13 @@ void DialogClientView::OnPaint(gfx::Canvas* canvas) {
FillViewWithSysColor(canvas, this, GetSysColor(COLOR_3DFACE));
#elif defined(USE_WAYLAND) || defined(USE_AURA)
SkColor sk_color = SkColorSetARGB(200, 255, 255, 255);
- canvas->FillRectInt(sk_color, 0, 0, width(), height());
+ canvas->FillRect(sk_color, GetLocalBounds());
#else
GtkWidget* widget = GetWidget()->GetNativeView();
if (GTK_IS_WINDOW(widget)) {
GtkStyle* window_style = gtk_widget_get_style(widget);
- canvas->FillRectInt(gfx::GdkColorToSkColor(
- window_style->bg[GTK_STATE_NORMAL]),
- 0, 0, width(), height());
+ canvas->FillRect(gfx::GdkColorToSkColor(window_style->bg[GTK_STATE_NORMAL]),
+ GetLocalBounds());
}
#endif
}
« views/window/custom_frame_view.cc ('K') | « views/window/custom_frame_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698