Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: chrome/browser/tab_contents/thumbnail_generator_unittest.cc

Issue 8405002: ui/gfx: Convert Canvas::FillRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/thumbnail_generator_unittest.cc
diff --git a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
index b96333d4a5384faf30e45a0edc21b8fc62aa38d0..1fda77c4cab636fa6bad33fa32414499a0647d4b 100644
--- a/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
+++ b/chrome/browser/tab_contents/thumbnail_generator_unittest.cc
@@ -13,8 +13,8 @@
#include "content/browser/renderer_host/mock_render_process_host.h"
#include "content/browser/renderer_host/test_render_view_host.h"
#include "content/browser/tab_contents/render_view_host_manager.h"
-#include "content/public/browser/notification_service.h"
#include "content/common/view_messages.h"
+#include "content/public/browser/notification_service.h"
#include "content/public/browser/notification_types.h"
#include "skia/ext/platform_canvas.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -220,7 +220,7 @@ TEST_F(ThumbnailGeneratorSimpleTest, CalculateBoringScore_SingleColor) {
const gfx::Size kSize(20, 10);
gfx::CanvasSkia canvas(kSize.width(), kSize.height(), true);
// Fill all pixesl in black.
- canvas.FillRectInt(kBlack, 0, 0, kSize.width(), kSize.height());
+ canvas.FillRect(kBlack, gfx::Rect(0, 0, kSize.width(), kSize.height()));
Peter Kasting 2011/10/27 19:17:29 Nit: Shorter: gfx::Rect(gfx::Point(), kSize); (2 p
tfarina 2011/10/27 20:46:03 Done.
SkBitmap bitmap =
skia::GetTopDevice(*canvas.sk_canvas())->accessBitmap(false);
@@ -235,9 +235,9 @@ TEST_F(ThumbnailGeneratorSimpleTest, CalculateBoringScore_TwoColors) {
gfx::CanvasSkia canvas(kSize.width(), kSize.height(), true);
// Fill all pixesl in black.
- canvas.FillRectInt(kBlack, 0, 0, kSize.width(), kSize.height());
+ canvas.FillRect(kBlack, gfx::Rect(0, 0, kSize.width(), kSize.height()));
// Fill the left half pixels in white.
- canvas.FillRectInt(kWhite, 0, 0, kSize.width() / 2, kSize.height());
+ canvas.FillRect(kWhite, gfx::Rect(0, 0, kSize.width() / 2, kSize.height()));
SkBitmap bitmap =
skia::GetTopDevice(*canvas.sk_canvas())->accessBitmap(false);

Powered by Google App Engine
This is Rietveld 408576698