Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: content/browser/download/download_file_unittest.cc

Issue 8404049: Added member data to classes to support download resumption. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merged with trunk Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_unittest.cc
diff --git a/content/browser/download/download_file_unittest.cc b/content/browser/download/download_file_unittest.cc
index 2fcb51cde5f481cd3074d32a5cc7d1829a06e02f..14c4e35aa2235b7a650034344961ea5fba925411 100644
--- a/content/browser/download/download_file_unittest.cc
+++ b/content/browser/download/download_file_unittest.cc
@@ -73,7 +73,7 @@ class DownloadFileTest : public testing::Test {
info.save_info.file_stream = file_stream_;
file->reset(
new DownloadFileImpl(&info, new DownloadRequestHandle(),
- download_manager_));
+ download_manager_, Pickle()));
}
virtual void DestroyDownloadFile(scoped_ptr<DownloadFile>* file, int offset) {
@@ -181,10 +181,6 @@ TEST_F(DownloadFileTest, RenameFileFinal) {
EXPECT_FALSE(file_util::PathExists(path_2));
EXPECT_TRUE(file_util::PathExists(path_3));
- // Should not be able to get the hash until the file is closed.
- std::string hash;
- EXPECT_FALSE(download_file_->GetSha256Hash(&hash));
-
download_file_->Finish();
// Rename the file after downloading all the data and closing the file.
@@ -197,6 +193,7 @@ TEST_F(DownloadFileTest, RenameFileFinal) {
EXPECT_TRUE(file_util::PathExists(path_4));
// Check the hash.
+ std::string hash;
EXPECT_TRUE(download_file_->GetSha256Hash(&hash));
EXPECT_EQ(kDataHash, base::HexEncode(hash.data(), hash.size()));

Powered by Google App Engine
This is Rietveld 408576698