chrome/browser/tab_contents/render_view_host_delegate_helper.cc - Issue 8404046: When creating a tab contents for a browser in the RVHDelegateHelper, create a wrapper immediately.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Issue 8404046: When creating a tab contents for a browser in the RVHDelegateHelper, create a wrapper immediately. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webrequest_apitest.cc ('k') | chrome/browser/ui/browser.h » ('j') | chrome/test/data/extensions/api_test/webrequest/framework.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

diff --git a/chrome/browser/tab_contents/render_view_host_delegate_helper.cc b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

index d2e9bce2e78fc0084e56644320aaa52359b8417a..9533c760e27bc81cefb96e80e0cae05aa1eb2364 100644

--- a/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

+++ b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

@@ -263,6 +263,9 @@ TabContents* RenderViewHostDelegateViewHelper::CreateNewWindowFromTabContents(

params.frame_name);

if (new_contents) {

+ if (tab_contents->delegate())

+ tab_contents->delegate()->TabContentsCreated(new_contents);

content::RetargetingDetails details;

details.source_tab_contents = tab_contents;

details.source_frame_id = params.opener_frame_id;

@@ -273,9 +276,6 @@ TabContents* RenderViewHostDelegateViewHelper::CreateNewWindowFromTabContents(

content::Source<content::BrowserContext>(

tab_contents->browser_context()),

content::Details<content::RetargetingDetails>(&details));

- if (tab_contents->delegate())

- tab_contents->delegate()->TabContentsCreated(new_contents);

} else {

content::NotificationService::current()->Notify(

content::NOTIFICATION_CREATING_NEW_WINDOW_CANCELLED,