Strip comments from shader before checking for invalid characters

Strip comments from shader before checking for invalid characters

BUG=101870
TEST=unit tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107631

[greggman, 2011-10-27 07:19:47]

Hey John, can you please review this. Thank you.

[jbauman, 2011-10-27 17:58:59]

lgtm. Thanks for getting this done so quickly.

[jbauman, 2011-10-27 18:02:01]

http://codereview.chromium.org/8404029/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8404029/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4763:
info->UpdateSource(str.c_str());
Actually, if we're worried about unusual characters messing up the underlying gl
implementation, should we be using stripped here?

[greggman, 2011-10-27 19:11:30]

On 2011/10/27 18:02:01, jbauman wrote:
>
http://codereview.chromium.org/8404029/diff/1/gpu/command_buffer/service/gles...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
http://codereview.chromium.org/8404029/diff/1/gpu/command_buffer/service/gles...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:4763:
> info->UpdateSource(str.c_str());
> Actually, if we're worried about unusual characters messing up the underlying
gl
> implementation, should we be using stripped here?

Sadly i can't strip them there without a much larger change because
glGetShaderSource is supposed to return what the user gives it.

I believe the ANGLE shader translator strips them.

I could add an issue to store both stripped and unstripped

[commit-bot: I haz the power, 2011-10-27 20:34:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/8404029/1

[commit-bot: I haz the power, 2011-10-27 21:42:43]

Change committed as 107631