Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 8404026: Add a command line flag (--enable-fixed-position-compositing) for enabling compositing (Closed)

Created:
9 years, 1 month ago by Vangelis Kokkevis
Modified:
9 years, 1 month ago
Reviewers:
vangelis, jamesr, jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a command line flag (--enable-fixed-position-compositing) for enabling compositing of fixed position elements. BUG=None TEST=Manual testing to verify the flag works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108166

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vangelis
Please review. This CL must land after https://bugs.webkit.org/show_bug.cgi?id=69796 is checked in and the DEPS are ...
9 years, 1 month ago (2011-10-27 05:58:12 UTC) #1
jamesr
lgtm http://codereview.chromium.org/8404026/diff/1/content/browser/renderer_host/browser_render_process_host.cc File content/browser/renderer_host/browser_render_process_host.cc (right): http://codereview.chromium.org/8404026/diff/1/content/browser/renderer_host/browser_render_process_host.cc#newcode570 content/browser/renderer_host/browser_render_process_host.cc:570: switches::kEnableCompositingForFixedPosition, why is this here? i know we ...
9 years, 1 month ago (2011-10-27 06:19:52 UTC) #2
vangelis
On 2011/10/27 06:19:52, jamesr wrote: > lgtm > > http://codereview.chromium.org/8404026/diff/1/content/browser/renderer_host/browser_render_process_host.cc > File content/browser/renderer_host/browser_render_process_host.cc (right): > ...
9 years, 1 month ago (2011-10-27 06:33:04 UTC) #3
vangelis
John, can I get an OWNERS ok too? Thanks!
9 years, 1 month ago (2011-10-28 23:19:39 UTC) #4
jam
9 years, 1 month ago (2011-10-31 05:05:47 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698