Issue 8404022: Fix yet another crash with bookmarks drag&drop on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8404022: Fix yet another crash with bookmarks drag&drop on Mac. (Closed)

Created:
9 years, 1 month ago by Ilya Sherman

Modified:
9 years, 1 month ago

Reviewers:
Robert Sesek, Miranda Callahan

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix yet another crash with bookmarks drag&drop on Mac. Try a different, simpler approach to detect bookmark drag&drop across profiles. BUG=101543 TEST=drag bookmark from folder, wait for folder to close, drop on bar -> no crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107572

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -61 lines)			Patch
M	chrome/browser/bookmarks/bookmark_model.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View	1 chunk	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm	View	4 chunks	+10 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm	View	1 chunk	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_unittest.mm	View	5 chunks	+30 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

First reviewer wins! Please tick the commit queue checkbox if all looks good.

9 years, 1 month ago (2011-10-27 01:56:20 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8404022/1

9 years, 1 month ago (2011-10-27 14:22:34 UTC) #3

Change committed as 107572

Expand Messages | Collapse Messages