Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: content/browser/webkit_browsertest.cc

Issue 8404001: Add a browsertest for bug 75604 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: lintey fixey Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webkit_browsertest.cc
diff --git a/content/browser/webkit_browsertest.cc b/content/browser/webkit_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d36a62af7c4e3c312c1905442029bfddfbbb9e51
--- /dev/null
+++ b/content/browser/webkit_browsertest.cc
@@ -0,0 +1,34 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/browser.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/ui_test_utils.h"
+#include "content/browser/net/url_request_abort_on_end_job.h"
+#include "content/browser/tab_contents/tab_contents.h"
+
+typedef InProcessBrowserTest WebKitBrowserTest;
+
+const char kAsyncScriptThatAbortsOnEndPage[] =
+ "files/webkit/async_script_abort_on_end.html";
+
+// This is a browser test because it is hard to reproduce reliably in a
+// layout test without races. http://crbug.com/75604 deals with a request
+// for an async script which gets data in the response and immediately
+// after aborts. This test creates that condition, and it is passed
+// if chrome does not crash.
+
+IN_PROC_BROWSER_TEST_F(WebKitBrowserTest, AbortOnEnd) {
+ ASSERT_TRUE(test_server()->Start());
+ URLRequestAbortOnEndJob::AddUrlHandler();
+ GURL url = test_server()->GetURL(kAsyncScriptThatAbortsOnEndPage);
+
+ ui_test_utils::NavigateToURL(browser(), url);
+
+ // TODO(gavinp): after bug 75604 is fixed in WebKit, update expectations
Paweł Hajdan Jr. 2011/10/27 08:52:58 I think it'd be safer strategy to omit this check
gavinp 2011/10/27 12:52:53 I'd really like to see this test pass as it is on
+ // so that this test is not expected to crash.
+ TabContents* tab_contents = browser()->GetSelectedTabContents();
+ EXPECT_TRUE(tab_contents->is_crashed());
+}
+

Powered by Google App Engine
This is Rietveld 408576698