Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java

Issue 8403040: Don't wait unnecessarily. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java
===================================================================
--- compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java (revision 734)
+++ compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java (working copy)
@@ -271,7 +271,7 @@
*/
private void generateProxyClass(DartClass clazz) {
String name = clazz.getClassName();
- p("interface " + name + "$Proxy {");
+ p("interface " + name + "$Proxy extends Proxy {");
printProxyInterfaceFunctions(clazz);
p("}");
nl();
@@ -411,22 +411,12 @@
p("\") {");
nl();
int proxies = unpackParams(member);
- String extra = "";
if (proxies != 0) {
- p(" Promise done = new Promise();");
- nl();
- p(" done.waitFor(promises, " + proxies + ");");
- nl();
- p(" done.addCompleteHandler((_) {");
- nl();
+ // FIXME(benl): we don't need to gather them anymore, could just pass them directly. Too
+ // lazy right now.
gatherProxies(member);
- extra = " ";
}
- callTarget((DartMethodDefinition)member, extra);
- if (proxies != 0) {
- p(" });");
- nl();
- }
+ callTarget((DartMethodDefinition)member, "");
p(" }");
first = false;
}
@@ -648,7 +638,7 @@
boolean isSimpleType = isSimpleType(x.getTypeNode());
if (!isSimpleType) {
- p(" ");
+ p(" ");
accept(x.getTypeNode());
p(" ");
accept(x.getName());

Powered by Google App Engine
This is Rietveld 408576698