Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java

Issue 8403040: Don't wait unnecessarily. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
===================================================================
--- compiler/java/com/google/dart/compiler/DartCompilerMainContext.java (revision 1134)
+++ compiler/java/com/google/dart/compiler/DartCompilerMainContext.java (working copy)
@@ -8,6 +8,7 @@
import com.google.dart.compiler.ast.LibraryUnit;
import com.google.dart.compiler.metrics.CompilerMetrics;
import com.google.dart.compiler.parser.DartParser;
+import com.google.dart.compiler.resolver.ResolverErrorCode;
import com.google.dart.compiler.resolver.TypeErrorCode;
import java.io.IOException;
@@ -56,7 +57,8 @@
(event.getErrorCode() != TypeErrorCode.NO_SUCH_TYPE) &&
(event.getErrorCode() != TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED)))) {
incrementTypeErrorCount();
- } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR) {
+ } else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.ERROR &&
+ (!shouldWarnOnNoSuchType() || event.getErrorCode() != ResolverErrorCode.NO_SUCH_TYPE)) {
incrementErrorCount();
} else if (event.getErrorCode().getErrorSeverity() == ErrorSeverity.WARNING) {
incrementWarningCount();
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/backend/isolate/DartIsolateStubGenerator.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698