Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: tests/stub-generator/testcfg.py

Issue 8403040: Don't wait unnecessarily. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/stub-generator/testcfg.py
===================================================================
--- tests/stub-generator/testcfg.py (revision 999)
+++ tests/stub-generator/testcfg.py (working copy)
@@ -39,6 +39,9 @@
(interface, _, implementation) = interface.partition('+')
return (interface, classes, implementation)
+ def IsFailureOutput(self, output):
floitsch 2011/11/02 14:34:27 Are you sure this is necessary? Do all components
Ben Laurie (Google) 2011/11/02 14:45:44 Yes, without it the test can exit early and appear
floitsch 2011/11/02 16:04:17 The testing-infrastructure should make sure this i
Ben Laurie (Google) 2011/11/02 21:09:34 How? AFAICS it does not achieve that: for example,
+ return output.exit_code != 0 or not '##DONE##' in output.stdout
+
def BeforeRun(self):
if not self.context.generate:
return

Powered by Google App Engine
This is Rietveld 408576698