Don't wait unnecessarily.

tests/stub-generator/testcfg.py

 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import os
 import re
 import shutil
 import sys
 import tempfile
 
@@ skipping 21 matching lines @@
   def GetStubs(self):
     source = self.GetSource()
     stub_classes = utils.ParseTestOptions(test.ISOLATE_STUB_PATTERN, source,
                                           self.context.workspace)
     if stub_classes is None:
       return (None, None, None)
     (interface, _, classes) = stub_classes[0].partition(':')
     (interface, _, implementation) = interface.partition('+')
     return (interface, classes, implementation)
 
+  def IsFailureOutput(self, output):

[floitsch, 2011/11/02 14:34:27]

Are you sure this is necessary?
Do all components now support 'print' in testing mode?

[Ben Laurie (Google), 2011/11/02 14:45:44]

Yes, without it the test can exit early and appear to work even though it does
not.
I don't know, but we need _some_ equivalent mechanism or we cannot, in general,
test asynchronous code.

Being able to set an exit code would be another example of a method that should
work.

[floitsch, 2011/11/02 16:04:17]

The testing-infrastructure should make sure this is not the case. If not, please
give us an example so that we can fix the test-framework. (This is the whole
reason why you have to write expect.succeeded().)

[Ben Laurie (Google), 2011/11/02 21:09:34]

How? AFAICS it does not achieve that: for example, if I return with outstanding
promises, the result is never tested.

+    return output.exit_code != 0 or not '##DONE##' in output.stdout
+
   def BeforeRun(self):
     if not self.context.generate:
       return
     (interface, classes, _) = self.GetStubs()
     if interface is None:
       return
     d = join(self.GetPath(), 'generated')
     if not isdir(d):
       os.mkdir(d)
     tmpdir = tempfile.mkdtemp()
@@ skipping 74 matching lines @@
                                       test_path,
                                       join(root, f),
                                       mode,
                                       arch,
                                       component))
     return tests
 
 
 def GetConfiguration(context, root):
   return DartStubTestConfiguration(context, root)