Issue 8403037: Make C++ to JS transition faster by avoiding JavaScriptFrameIterator in SaveContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8403037: Make C++ to JS transition faster by avoiding JavaScriptFrameIterator in SaveContext. (Closed)

Created:
9 years, 1 month ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 1 month ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make C++ to JS transition faster by avoiding JavaScriptFrameIterator in SaveContext. R=kmillikin@chromium.org BUG=v8:1730 Committed: http://code.google.com/p/v8/source/detail?r=9835

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -17 lines)			Patch
M	src/isolate.h	View	2 chunks	+5 lines, -4 lines	1 comment	Download
M	src/isolate-inl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 1 month ago (2011-10-28 11:09:08 UTC) #3

LGTM, but I really think the stack grows upward.

http://codereview.chromium.org/8403037/diff/1/src/isolate.h
File src/isolate.h (right):

http://codereview.chromium.org/8403037/diff/1/src/isolate.h#newcode1249
src/isolate.h:1249: bool IsAboveFrame(JavaScriptFrame* frame) {
Let's rename this to use "Below", and you can change the comment to say:

Returns true if this save context is below a given JavaScript frame (i.e., at a
higher address).

Expand Messages | Collapse Messages