Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 8403036: Remove kInvalidStrictFlag and make gcc-4.5 happy again. (Closed)

Created:
9 years, 1 month ago by Steven
Modified:
9 years, 1 month ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Remove kInvalidStrictFlag and make gcc-4.5 happy again. Committed: http://code.google.com/p/v8/source/detail?r=9832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M src/globals.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/objects.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 6 chunks +18 lines, -14 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
PTAL. Removed the flag, fixed the following error and did some cleanups. ../src/runtime.cc: In function ...
9 years, 1 month ago (2011-10-27 13:17:40 UTC) #1
Lasse Reichstein
9 years, 1 month ago (2011-10-28 08:32:45 UTC) #2
LGTM.

If you want fewer repetitions (which really isn't necessary), you could have a
static function converting int to StrictModeFlag somewhere, and have it do the
checking.

Powered by Google App Engine
This is Rietveld 408576698