Issue 8403035: Tiny improvements on fast element conversion loops in ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8403035: Tiny improvements on fast element conversion loops in ia32 and x64. (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Tiny improvements on fast element conversion loops in ia32 and x64. Committed: http://code.google.com/p/v8/source/detail?r=9820

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		4 chunks	+4 lines, -6 lines	1 comment	Download
	M	src/x64/codegen-x64.cc	View		4 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

9 years, 1 month ago (2011-10-27 13:33:07 UTC) #2

LGTM with nits.

http://codereview.chromium.org/8403035/diff/1/src/ia32/codegen-ia32.cc
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/8403035/diff/1/src/ia32/codegen-ia32.cc#newcod...
src/ia32/codegen-ia32.cc:358: // edi: number of elements to convert/copy
At this point %edi is actually the index of the last element to be converted.
The above comment should be fixed.

Expand Messages | Collapse Messages