Issue 8403023: base::Bind: Finish conversion in ServiceProcessControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8403023: base::Bind: Finish conversion in ServiceProcessControl. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind: Finish conversion in ServiceProcessControl. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107878

Patch Set 2 : Save space. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -25 lines)			Patch
M	chrome/browser/service/service_process_control.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/service/service_process_control.cc	View	1	4 chunks	+22 lines, -19 lines	0 comments	Download
M	chrome/browser/service/service_process_control_mac.mm	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8403023/diff/1/chrome/browser/service/service_process_control.cc File chrome/browser/service/service_process_control.cc (right): http://codereview.chromium.org/8403023/diff/1/chrome/browser/service/service_process_control.cc#newcode151 chrome/browser/service/service_process_control.cc:151: base::Unretained(this))); could you clarify why you're using Unretained ...

9 years, 1 month ago (2011-10-28 22:58:15 UTC) #2

James Hawkins

9 years, 1 month ago (2011-10-29 17:43:33 UTC) #3

http://codereview.chromium.org/8403023/diff/1/chrome/browser/service/service_...
File chrome/browser/service/service_process_control.cc (right):

http://codereview.chromium.org/8403023/diff/1/chrome/browser/service/service_...
chrome/browser/service/service_process_control.cc:151: base::Unretained(this)));
On 2011/10/28 22:58:15, csilv wrote:
> could you clarify why you're using Unretained here?

ServiceProcessControl is not ref-counted.  The other base::Bind changes in this
file are for ServiceProcessControl::Launcher, which is ref-counted.

Expand Messages | Collapse Messages

Issue 8403023: base::Bind: Finish conversion in ServiceProcessControl. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Save space. #

Messages