Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 8403017: Rename URLFetcher to be URLFetcherImpl, now that we have the content::URLFetcher interface. (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, ncarter (slow), Raghu Simha, Erik does not do reviews, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org, akalin
Visibility:
Public.

Description

Rename URLFetcher to be URLFetcherImpl, now that we have the content::URLFetcher interface. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107531

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : don't make content files use API #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -2231 lines) Patch
M chrome/browser/chromeos/login/cookie_fetcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/google_authenticator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_auth_response_handler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_auth_response_handler.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/google/google_url_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 5 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/policy/cloud_policy_subsystem_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/device_management_service_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 14 chunks +15 lines, -14 lines 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_helpers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/service_process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_request.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/speech/speech_recognition_request.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
D content/common/net/url_fetcher.h View 1 chunk +0 lines, -124 lines 0 comments Download
D content/common/net/url_fetcher.cc View 1 chunk +0 lines, -1109 lines 0 comments Download
A + content/common/net/url_fetcher_impl.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + content/common/net/url_fetcher_impl.cc View 1 40 chunks +105 lines, -104 lines 0 comments Download
A + content/common/net/url_fetcher_impl_unittest.cc View 1 2 10 chunks +12 lines, -11 lines 0 comments Download
D content/common/net/url_fetcher_unittest.cc View 1 chunk +0 lines, -801 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_url_fetcher_factory.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-10-27 00:33:10 UTC) #1
willchan no longer on Chromium
9 years, 1 month ago (2011-10-27 00:34:11 UTC) #2
Rubberstamp lgtm

On Wed, Oct 26, 2011 at 5:33 PM, <jam@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Rename URLFetcher to be URLFetcherImpl, now that we have the
> content::URLFetcher
> interface.
>
> BUG=98716
> TBR=willchan
>
> Please review this at
http://codereview.chromium.**org/8403017/<http://codereview.chromium.org/8403...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/chromeos/login/**cookie_fetcher_unittest.cc
>  M     chrome/browser/chromeos/login/**google_authenticator_unittest.**cc
>  M     chrome/browser/chromeos/login/**mock_auth_response_handler.h
>  M     chrome/browser/chromeos/login/**mock_auth_response_handler.cc
>  M     chrome/browser/chromeos/login/**parallel_authenticator_**
> unittest.cc
>  M     chrome/browser/component_**updater/component_updater_**
> service_unittest.cc
>  M     chrome/browser/extensions/**extension_management_**browsertest.cc
>  M     chrome/browser/extensions/**webstore_inline_installer.cc
>  M     chrome/browser/google/google_**url_tracker_unittest.cc
>  M     chrome/browser/net/gaia/gaia_**oauth_fetcher_unittest.cc
>  M     chrome/browser/policy/cloud_**policy_subsystem_unittest.cc
>  M     chrome/browser/policy/device_**management_service_**browsertest.cc
>  M     chrome/browser/safe_browsing/**client_side_detection_service_**
> unittest.cc
>  M     chrome/browser/safe_browsing/**download_protection_service_**
> unittest.cc
>  M     chrome/browser/safe_browsing/**safe_browsing_test.cc
>  M     chrome/browser/sync/glue/sync_**backend_host_unittest.cc
>  M     chrome/browser/sync/test/**integration/sync_test.cc
>  M     chrome/common/net/gaia/gaia_**auth_fetcher_unittest.h
>  M     chrome/common/net/gaia/gaia_**auth_fetcher_unittest.cc
>  M     chrome/common/net/gaia/gaia_**oauth_client_unittest.cc
>  M     chrome/service/cloud_print/**cloud_print_helpers.cc
>  M     chrome/service/cloud_print/**cloud_print_url_fetcher.h
>  M     chrome/service/cloud_print/**cloud_print_url_fetcher.cc
>  M     chrome/service/gaia/service_**gaia_authenticator.cc
>  M     chrome/service/service_**process.cc
>  M     content/browser/geolocation/**network_location_request.cc
>  M     content/browser/speech/speech_**recognition_request.cc
>  D     content/common/net/url_**fetcher.h
>  D     content/common/net/url_**fetcher.cc
>  A  +  content/common/net/url_**fetcher_impl.h
>  A  +  content/common/net/url_**fetcher_impl.cc
>  A  +  content/common/net/url_**fetcher_impl_unittest.cc
>  D     content/common/net/url_**fetcher_unittest.cc
>  M     content/content_common.gypi
>  M     content/content_tests.gypi
>  M     content/test/test_url_fetcher_**factory.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698