Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/ui/views/bubble/bubble.cc

Issue 8402031: aura: Initialize Widget to avoid a crash when showing bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bubble/bubble.cc
diff --git a/chrome/browser/ui/views/bubble/bubble.cc b/chrome/browser/ui/views/bubble/bubble.cc
index 73a2acf7469cc269e4f45196a159560815c24721..c923bed344baee574969e1c213230c7fc6f23fc3 100644
--- a/chrome/browser/ui/views/bubble/bubble.cc
+++ b/chrome/browser/ui/views/bubble/bubble.cc
@@ -203,8 +203,13 @@ void Bubble::InitBubble(views::Widget* parent,
// Create the main window.
#if defined(USE_AURA)
- // TODO(beng):
- NOTIMPLEMENTED();
+ views::Widget::InitParams params;
+ params.transparent = true;
+ params.parent_widget = parent;
+ params.native_widget = this;
+ GetWidget()->Init(params);
+ if (fade_in)
+ SetOpacity(0);
sadrul 2011/10/27 16:14:51 Are there more things to do here? Should I leave t
Ben Goodger (Google) 2011/10/27 16:16:38 Probably leave the TODO & the notimplemented. alic
sadrul 2011/10/27 16:29:50 Added back the TODO and NOTIMPLEMENTED, and an exp
#elif defined(OS_WIN)
views::Widget* parent_window = parent->GetTopLevelWidget();
if (parent_window)
@@ -307,8 +312,7 @@ void Bubble::InitBubble(views::Widget* parent,
// Show the window.
#if defined(USE_AURA)
- // TODO(beng):
- NOTIMPLEMENTED();
+ GetWidget()->Show();
#elif defined(OS_WIN)
border_->ShowWindow(SW_SHOW);
ShowWindow(SW_SHOW);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698