Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 8402031: aura: Initialize Widget to avoid a crash when showing bubbles. (Closed)

Created:
9 years, 1 month ago by sadrul
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

aura: Initialize Widget to avoid a crash when showing bubbles. BUG=97248 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107586

Patch Set 1 #

Total comments: 3

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/bubble.cc File chrome/browser/ui/views/bubble/bubble.cc (right): http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/bubble.cc#newcode212 chrome/browser/ui/views/bubble/bubble.cc:212: SetOpacity(0); Are there more things to do here? Should ...
9 years, 1 month ago (2011-10-27 16:14:51 UTC) #1
Ben Goodger (Google)
LGTM for wallpapering over the crash. http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/bubble.cc File chrome/browser/ui/views/bubble/bubble.cc (right): http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/bubble.cc#newcode212 chrome/browser/ui/views/bubble/bubble.cc:212: SetOpacity(0); On 2011/10/27 ...
9 years, 1 month ago (2011-10-27 16:16:38 UTC) #2
sadrul
9 years, 1 month ago (2011-10-27 16:29:50 UTC) #3
http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/...
File chrome/browser/ui/views/bubble/bubble.cc (right):

http://codereview.chromium.org/8402031/diff/1/chrome/browser/ui/views/bubble/...
chrome/browser/ui/views/bubble/bubble.cc:212: SetOpacity(0);
On 2011/10/27 16:16:38, Ben Goodger (Google) wrote:
> On 2011/10/27 16:14:51, sadrul wrote:
> > Are there more things to do here? Should I leave the TODO?
> 
> Probably leave the TODO & the notimplemented. alicet/msw are rewriting all the
> bubbles to use the new infrastructure.

Added back the TODO and NOTIMPLEMENTED, and an explanation NOTE.

Powered by Google App Engine
This is Rietveld 408576698