Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 8402023: Speak a message when accessibility is on and the network state changes (Closed)

Created:
9 years, 1 month ago by Zachary Kuznia
Modified:
9 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Speak a message when accessibility is on and the network state changes R=dmazzoni@chromium.org BUG=chromium-os:21760 TEST=Change the network state with a11y turned on Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107689

Patch Set 1 #

Patch Set 2 : Change the network menu icon test to a browser test. #

Patch Set 3 : Code review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M chrome/browser/chromeos/accessibility_util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility_util.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu_icon.cc View 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Zachary Kuznia
9 years, 1 month ago (2011-10-27 09:55:41 UTC) #1
dmazzoni
lgtm
9 years, 1 month ago (2011-10-27 13:15:00 UTC) #2
dmazzoni
lgtm lgtm
9 years, 1 month ago (2011-10-27 13:15:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/8402023/1
9 years, 1 month ago (2011-10-28 03:43:27 UTC) #4
commit-bot: I haz the power
Try job failure for 8402023-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-10-28 04:41:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/8402023/1
9 years, 1 month ago (2011-10-28 04:51:02 UTC) #6
commit-bot: I haz the power
Try job failure for 8402023-1 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-10-28 05:42:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/8402023/1
9 years, 1 month ago (2011-10-28 05:45:42 UTC) #8
commit-bot: I haz the power
Change committed as 107689
9 years, 1 month ago (2011-10-28 06:47:56 UTC) #9
Zachary Kuznia
9 years, 1 month ago (2011-11-09 03:58:56 UTC) #10

          

Powered by Google App Engine
This is Rietveld 408576698