Issue 8402020: chromeos: initializer for power supply status struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8402020: chromeos: initializer for power supply status struct (Closed)

Created:
9 years, 1 month ago by Simon Que

Modified:
9 years, 1 month ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, oshima, stevenjb

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

chromeos: initializer for power supply status struct This eliminates the need to explicitly initialize it with "= {}" everywhere. BUG=chromium:101867 TEST=Valgrind error should not happen (see bug) Signed-off-by: Simon Que <sque@chromium.org>; R=satorux@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107548

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
M	chrome/browser/chromeos/cros/power_library.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/power_library.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/status/power_menu_button_browsertest.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

oshima

can you remove suppression as well? On Wed, Oct 26, 2011 at 11:02 PM, <satorux@chromium.org> ...

9 years, 1 month ago (2011-10-27 06:30:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sque@chromium.org/8402020/3001

9 years, 1 month ago (2011-10-27 07:34:20 UTC) #5

Change committed as 107548