Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 8402018: Fix build on the "Linux Clang (ChromeOS dbg)" bot. (Closed)

Created:
9 years, 1 month ago by Hironori Bono
Modified:
9 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix build on the "Linux Clang (ChromeOS dbg)" bot. This change just adds a 'const' to RenderWidgetHostViewViews::HasFocus() to match it with views::View::HasFocus(). BUG=none TEST=fix the "Linux Clang (ChromeOS dbg)" build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107534

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hironori Bono
9 years, 1 month ago (2011-10-27 02:28:41 UTC) #1
Peter Mayo
lgtm
9 years, 1 month ago (2011-10-27 03:00:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8402018/1
9 years, 1 month ago (2011-10-27 03:02:53 UTC) #3
sky
LGTM
9 years, 1 month ago (2011-10-27 03:03:56 UTC) #4
Peter Kasting
Sorry about this... (LGTM)
9 years, 1 month ago (2011-10-27 03:41:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8402018/6010
9 years, 1 month ago (2011-10-27 05:26:24 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 06:30:13 UTC) #7
Change committed as 107534

Powered by Google App Engine
This is Rietveld 408576698