Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/sync/engine/apply_updates_command_unittest.cc

Issue 8402014: [Sync] Make GetFirstChildId return a flag indicating success (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/nigori_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/apply_updates_command_unittest.cc
diff --git a/chrome/browser/sync/engine/apply_updates_command_unittest.cc b/chrome/browser/sync/engine/apply_updates_command_unittest.cc
index 7ea70c371bc1b4431b5c6e35e634990f240c37bb..852379137544a54142a6c7fe76cfdbf3c1968309 100644
--- a/chrome/browser/sync/engine/apply_updates_command_unittest.cc
+++ b/chrome/browser/sync/engine/apply_updates_command_unittest.cc
@@ -113,7 +113,9 @@ class ApplyUpdatesCommandTest : public SyncerCommandTest {
ScopedDirLookup dir(syncdb()->manager(), syncdb()->name());
ASSERT_TRUE(dir.good());
WriteTransaction trans(FROM_HERE, UNITTEST, dir);
- Id predecessor_id = dir->GetLastChildId(&trans, parent_id);
+ Id predecessor_id;
+ ASSERT_TRUE(
+ dir->GetLastChildIdForTest(&trans, parent_id, &predecessor_id));
MutableEntry entry(&trans, syncable::CREATE, parent_id, name);
ASSERT_TRUE(entry.good());
entry.Put(syncable::ID, item_id);
« no previous file with comments | « no previous file | chrome/browser/sync/engine/nigori_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698