[Sync] Make GetFirstChildId return a flag indicating success

chrome/browser/sync/internal_api/base_node.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/internal_api/base_node.h"
 
 #include "base/base64.h"
 #include "base/sha1.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 206 matching lines @@
 int64 BaseNode::GetSuccessorId() const {
   syncable::Id id_string = GetEntry()->Get(syncable::NEXT_ID);
   if (id_string.IsRoot())
     return kInvalidId;
   return IdToMetahandle(GetTransaction()->GetWrappedTrans(), id_string);
 }
 
 int64 BaseNode::GetFirstChildId() const {
   syncable::Directory* dir = GetTransaction()->GetLookup();
   syncable::BaseTransaction* trans = GetTransaction()->GetWrappedTrans();
-  syncable::Id id_string =
-      dir->GetFirstChildId(trans, GetEntry()->Get(syncable::ID));
+  syncable::Id id_string;
+  // TODO(akalin): Propagate up the error further (see
+  // http://crbug.com/100907).
+  CHECK(dir->GetFirstChildId(trans,
+                             GetEntry()->Get(syncable::ID), &id_string));
   if (id_string.IsRoot())
     return kInvalidId;
   return IdToMetahandle(GetTransaction()->GetWrappedTrans(), id_string);
 }
 
 DictionaryValue* BaseNode::GetSummaryAsValue() const {
   DictionaryValue* node_info = new DictionaryValue();
   node_info->SetString("id", base::Int64ToString(GetId()));
   node_info->SetBoolean("isFolder", GetIsFolder());
   node_info->SetString("title", GetTitle());
@@ skipping 96 matching lines @@
     const sync_pb::EntitySpecifics& specifics) {
   syncable::ModelType type = syncable::GetModelTypeFromSpecifics(specifics);
   DCHECK_NE(syncable::UNSPECIFIED, type);
   if (GetModelType() != syncable::UNSPECIFIED) {
     DCHECK_EQ(GetModelType(), type);
   }
   unencrypted_data_.CopyFrom(specifics);
 }
 
 }  // namespace sync_api