Issue 8401034: Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8401034: Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression. (Closed)

Created:
9 years, 1 month ago by vsevik

Modified:
9 years, 1 month ago

Reviewers:
vsevik

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/912/

Visibility:
Public.

Description

Merge 98454 - Web Inspector: Debugger fails when there is an invalid watch expression. https://bugs.webkit.org/show_bug.cgi?id=70718 Reviewed by Pavel Feldman. Source/WebCore: Test: inspector/debugger/watch-expressions-panel-switch.html * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): LayoutTests: * inspector/debugger/error-in-watch-expressions.html: * inspector/debugger/watch-expressions-panel-switch-expected.txt: Added. * inspector/debugger/watch-expressions-panel-switch.html: Added. * platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt: Added. BUG=101496 TBR=vsevik@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98583

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -0 lines)			Patch
M	LayoutTests/inspector/debugger/error-in-watch-expressions.html	View	1 chunk	+11 lines, -2 lines	0 comments	Download
A +	LayoutTests/inspector/debugger/watch-expressions-panel-switch.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/inspector/debugger/watch-expressions-panel-switch-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/platform/chromium/inspector/debugger/watch-expressions-panel-switch-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/inspector/front-end/ScriptsPanel.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages