top sites: allow TopSites to return all 20 cached sites

top sites: allow TopSites to return all 20 cached sites

TopSites was returning just 8 (because that is how many MostVisited needs). However now that we can have more than one consumer of TopSites (the other being an extension), we should leave it up to the consumer to decide how many they want to use. (most_visited.js already slices off the top 8 so no change is needed there)

BUG=100394
TEST=manual

committed r108172

[sky, 2011-10-27 16:16:27]

http://codereview.chromium.org/8401026/diff/1/chrome/browser/history/top_site...
File chrome/browser/history/top_sites.cc (right):

http://codereview.chromium.org/8401026/diff/1/chrome/browser/history/top_site...
chrome/browser/history/top_sites.cc:736: for (size_t pinned_index = 0;
pinned_index < kTopSitesShown; pinned_index++) {
I think you want to change this one too. At which point you can likely remove
kTopSitesShown.

[Evan Stade, 2011-10-27 16:31:21]

http://codereview.chromium.org/8401026/diff/1/chrome/browser/history/top_site...
File chrome/browser/history/top_sites.cc (right):

http://codereview.chromium.org/8401026/diff/1/chrome/browser/history/top_site...
chrome/browser/history/top_sites.cc:736: for (size_t pinned_index = 0;
pinned_index < kTopSitesShown; pinned_index++) {
On 2011/10/27 16:16:27, sky wrote:
> I think you want to change this one too. At which point you can likely remove
> kTopSitesShown.

well technically I can remove all the pinning code as we aren't using it but I'm
afraid we'll want to go back to it some day.

but yea I'll update this one for now as well.

[Evan Stade, 2011-10-31 20:17:18]

updated

[sky, 2011-10-31 20:49:19]

LGTM

[commit-bot: I haz the power, 2011-11-01 00:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/8401026/5001

[commit-bot: I haz the power, 2011-11-01 01:20:59]

Try job failure for 8401026-5001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...