Issue 8401023: Fix flakiness in NewTab() calls of AppApiTest browser_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8401023: Fix flakiness in NewTab() calls of AppApiTest browser_test. (Closed)

Created:
9 years, 1 month ago by Charlie Reis

Modified:
9 years, 1 month ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix flakiness in NewTab() calls of AppApiTest browser_test. BUG=88316 TEST=AppApiTest.{AppProcess,AppProcessInstances} not flaky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107582

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -20 lines)			Patch
	M	chrome/browser/extensions/app_process_apitest.cc	View		8 chunks	+39 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Here's another attempt at landing http://codereview.chromium.org/8393026/, but with several logging statements added. I can't seem ...

9 years, 1 month ago (2011-10-27 01:25:26 UTC) #1

Paweł Hajdan Jr.

9 years, 1 month ago (2011-10-27 08:45:36 UTC) #2

LGTM

You can use chromium-build-logs.appspot.com to look for the failures, it can get
you results faster than if someone decides to send you the logs after seeing the
failure instead of ignoring it.

Expand Messages | Collapse Messages