Add DART_CHECKVALID

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 19 matching lines @@
 DART_EXPORT bool Dart_IsValid(const Dart_Handle& handle) {
   ASSERT(Isolate::Current() != NULL);
   Zone zone;  // Setup a VM zone as we are creating some handles.
   HandleScope scope;  // Setup a VM handle scope.
 
   // Make sure that the object isn't an ApiFailure.
   const Object& obj = Object::Handle(Api::UnwrapHandle(handle));
   return !obj.IsApiFailure();
 }
 
+
+DART_EXPORT void _Dart_ReportInvalidHandle(const char* file,
+                                           int line,
+                                           const char* handle,
+                                           const char* message) {
+  fprintf(stderr, "%s:%d: invalid handle: '%s':\n    '%s'\n",
+          file, line, handle, message);
+  OS::Abort();

[siva, 2011/10/31 19:49:22]

If we expect embedding code to use this then OS::Abort might be a bit harsh. I
am thinking of the scenario where some server is embedding the VM and abort
might not be the right thing.
I think this is ok for now but we could consider making this as something only
the VM uses.

[turnidge, 2011/10/31 21:30:22]

My intention is that this is a convenience function for those who know that they
want to abort.  Those that do not want to abort will use Dart_IsValid and try to
recover gracefully.

+}
+
+
 DART_EXPORT const char* Dart_GetError(const Dart_Handle& handle) {
   ASSERT(Isolate::Current() != NULL);
   Zone zone;  // Setup a VM zone as we are creating some handles.
   HandleScope scope;  // Setup a VM handle scope.
   const Object& obj = Object::Handle(Api::UnwrapHandle(handle));
   if (!obj.IsApiFailure()) {
     return "";
   }
   ApiFailure& failure = ApiFailure::Handle();
   failure ^= obj.raw();
   const String& message = String::Handle(failure.message());
   const char* msg = message.ToCString();
   intptr_t len = strlen(msg) + 1;
   char* msg_copy = reinterpret_cast<char*>(Api::Allocate(len));
   OS::SNPrint(msg_copy, len, "%s", msg);
   return msg_copy;
 }
 
 
-DART_EXPORT Dart_Handle Dart_Error(const char* value) {
-  return Api::Error(value);
+DART_EXPORT Dart_Handle Dart_Error(const char* error) {
+  return Api::Error(error);
 }
 
 
 // TODO(iposva): This is a placeholder for the eventual external Dart API.
 DART_EXPORT bool Dart_Initialize(int argc,
                                  char** argv,
                                  Dart_IsolateInitCallback callback) {
   return Dart::InitOnce(argc, argv, callback);
 }
 
@@ skipping 1702 matching lines @@
   ASSERT(isolate != NULL);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   ApiLocalScope* scope = state->top_scope();
   ASSERT(scope != NULL);
   return scope->zone().Reallocate(ptr, old_size, new_size);
 }
 
 
 }  // namespace dart