Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: chrome/browser/ui/views/dropdown_bar_host_aura.cc

Issue 8401004: Gets the findbar to at least show up. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/dropdown_bar_host_aura.cc
===================================================================
--- chrome/browser/ui/views/dropdown_bar_host_aura.cc (revision 107374)
+++ chrome/browser/ui/views/dropdown_bar_host_aura.cc (working copy)
@@ -5,17 +5,18 @@
#include "chrome/browser/ui/views/dropdown_bar_host.h"
#include "base/logging.h"
+#include "ui/aura/window.h"
+#include "views/widget/widget.h"
NativeWebKeyboardEvent DropdownBarHost::GetKeyboardEvent(
const TabContents* contents,
const views::KeyEvent& key_event) {
- // TODO(beng):
- NOTIMPLEMENTED();
- return NativeWebKeyboardEvent();
+ return NativeWebKeyboardEvent(key_event.native_event());
}
void DropdownBarHost::SetWidgetPositionNative(const gfx::Rect& new_pos,
bool no_redraw) {
- // TODO(beng):
- NOTIMPLEMENTED();
+ if (!host_->IsVisible())
+ host_->GetNativeView()->Show();
+ host_->GetNativeView()->SetBounds(new_pos);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698