Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: content/browser/download/download_create_info.cc

Issue 8401001: Fix history importing by delaying DownloadManager creation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: " Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_create_info.cc
diff --git a/content/browser/download/download_create_info.cc b/content/browser/download/download_create_info.cc
index 72bb3237f5131709d0a4d6f2e4e076655cd479d4..4b5adc02b51426de11c37a2e967c8310a1d56e62 100644
--- a/content/browser/download/download_create_info.cc
+++ b/content/browser/download/download_create_info.cc
@@ -15,7 +15,7 @@ DownloadCreateInfo::DownloadCreateInfo(const FilePath& path,
int64 received_bytes,
int64 total_bytes,
int32 state,
- int32 download_id,
+ const DownloadId& download_id,
bool has_user_gesture,
content::PageTransition transition_type)
: path(path),
@@ -37,7 +37,7 @@ DownloadCreateInfo::DownloadCreateInfo()
received_bytes(0),
total_bytes(0),
state(-1),
- download_id(-1),
+ download_id(DownloadId::Invalid()),
has_user_gesture(false),
transition_type(content::PAGE_TRANSITION_LINK),
db_handle(0),
@@ -56,7 +56,7 @@ std::string DownloadCreateInfo::DebugString() const {
" total_bytes = %" PRId64
" prompt_user_for_save_location = %c"
" }",
- download_id,
+ download_id.local(),
Randy Smith (Not in Mondays) 2011/10/27 18:01:44 I'd be inclined to think that printing the domain
benjhayden 2011/10/27 19:04:41 Done.
url().spec().c_str(),
path.value().c_str(),
received_bytes,

Powered by Google App Engine
This is Rietveld 408576698