Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: content/browser/download/save_package.cc

Issue 8401001: Fix history importing by delaying DownloadManager creation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: alpha, bugfix Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/save_package.cc
diff --git a/content/browser/download/save_package.cc b/content/browser/download/save_package.cc
index be2c0518280d2102bdbe3e20d6be72795b09b814..e439ea174f8eef1ed32f5d922d468df137590aa3 100644
--- a/content/browser/download/save_package.cc
+++ b/content/browser/download/save_package.cc
@@ -21,6 +21,7 @@
#include "content/browser/browser_context.h"
#include "content/browser/browser_thread.h"
#include "content/browser/download/download_file_manager.h"
+#include "content/browser/download/download_id_factory.h"
#include "content/browser/download/download_item.h"
#include "content/browser/download/download_manager.h"
#include "content/browser/download/save_file.h"
@@ -30,6 +31,7 @@
#include "content/browser/renderer_host/render_view_host.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
#include "content/browser/renderer_host/resource_dispatcher_host.h"
+#include "content/browser/resource_context.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/common/view_messages.h"
#include "content/public/browser/content_browser_client.h"
@@ -268,7 +270,8 @@ bool SavePackage::Init() {
saved_main_file_path_,
page_url_,
browser_context->IsOffTheRecord(),
- download_manager_->GetNextId());
+ browser_context->GetDownloadManager()->
+ id_factory()->GetNextId());
Randy Smith (Not in Mondays) 2011/10/27 18:01:44 Where is id_factory() defined? I can't manage to
benjhayden 2011/10/27 19:04:41 In download_manager.h... This line is a continuati
Randy Smith (Not in Mondays) 2011/10/28 13:35:43 Whoops--sorry. Thanks.
benjhayden 2011/10/28 14:37:54 Done.
download_->AddObserver(this);
// Transfer ownership to the download manager.

Powered by Google App Engine
This is Rietveld 408576698