Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: content/browser/download/download_id_unittest.cc

Issue 8401001: Fix history importing by delaying DownloadManager creation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/download_id.h" 5 #include "content/browser/download/download_id.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
11 11
12 #include "content/browser/download/mock_download_manager.h"
12 #include "content/browser/download/mock_download_manager_delegate.h" 13 #include "content/browser/download/mock_download_manager_delegate.h"
13 #include "content/browser/download/mock_download_manager.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 class DownloadIdTest : public testing::Test { 16 class DownloadIdTest : public testing::Test {
17 public: 17 public:
18 DownloadIdTest() 18 DownloadIdTest()
19 : download_manager_delegate_(new MockDownloadManagerDelegate), 19 : download_manager_delegate_(new MockDownloadManagerDelegate),
20 ui_thread_(BrowserThread::UI, &message_loop_) { 20 ui_thread_(BrowserThread::UI, &message_loop_) {
21 num_managers_ = ARRAYSIZE_UNSAFE(download_managers_); 21 num_managers_ = ARRAYSIZE_UNSAFE(download_managers_);
22 std::vector<MockDownloadManager*> managers; 22 std::vector<MockDownloadManager*> managers;
23 managers.resize(num_managers_); 23 managers.resize(num_managers_);
24 size_t i; 24 size_t i;
25 // Create the download managers. 25 // Create the download managers.
26 for (i = 0; i < num_managers_; ++i) { 26 for (i = 0; i < num_managers_; ++i) {
27 managers[i] = 27 managers[i] =
28 new MockDownloadManager(download_manager_delegate_.get(), NULL); 28 new MockDownloadManager(download_manager_delegate_.get(), NULL, NULL);
29 } 29 }
30 // Sort by pointer value. 30 // Sort by pointer value.
31 std::sort(managers.begin(), managers.end()); 31 std::sort(managers.begin(), managers.end());
32 // Assign to |download_managers_|. 32 // Assign to |download_managers_|.
33 for (i = 0; i < num_managers_; ++i) { 33 for (i = 0; i < num_managers_; ++i) {
34 download_managers_[i] = managers[i]; 34 download_managers_[i] = managers[i];
35 managers[i] = NULL; 35 managers[i] = NULL;
36 } 36 }
37 } 37 }
38 38
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 EXPECT_EQ(kLocalId[2], map[id3]); 140 EXPECT_EQ(kLocalId[2], map[id3]);
141 last = map.end(); 141 last = map.end();
142 EXPECT_FALSE(last == map.find(id1)); 142 EXPECT_FALSE(last == map.find(id1));
143 EXPECT_FALSE(last == map.find(id2)); 143 EXPECT_FALSE(last == map.find(id2));
144 EXPECT_FALSE(last == map.find(id3)); 144 EXPECT_FALSE(last == map.find(id3));
145 145
146 EXPECT_FALSE(id1 == id2); 146 EXPECT_FALSE(id1 == id2);
147 EXPECT_LT(id1, id2); 147 EXPECT_LT(id1, id2);
148 } 148 }
149 149
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698