content/browser/download/download_id_factory.cc - Issue 8401001: Fix history importing by delaying DownloadManager creation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/download/download_id_factory.cc

Issue 8401001: Fix history importing by delaying DownloadManager creation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/download/download_id_factory.h"

	6

	7 #include "content/browser/download/download_id.h"

	8

	9 DownloadIdFactory::DownloadIdFactory(DownloadId::Domain domain)

	10 : domain_(domain),

	11 next_id_(0) {

	12 }

	13

	14 DownloadId DownloadIdFactory::GetNextId() {

	15 base::AutoLock lock(lock_);

	16 return DownloadId(domain_, next_id_++);
	Randy Smith (Not in Mondays) 2011/10/28 13:35:44 Nit's nit: For complex data types (i.e. most itera Nit's nit: For complex data types (i.e. most iterators) defaulting to pre-increment is better because it doesn't involve a copy. So I think it's useful to be in the habit of using pre-increment when it doesn't matter. This is just FYI; you're welcome to leave this code however you'd like. benjhayden 2011/10/28 14:37:55 Yeah, but I'd rather initialize the counter to the Show quoted text On 2011/10/28 13:35:44, rdsmith wrote: > Nit's nit: For complex data types (i.e. most iterators) defaulting to > pre-increment is better because it doesn't involve a copy. So I think it's > useful to be in the habit of using pre-increment when it doesn't matter. This > is just FYI; you're welcome to leave this code however you'd like. Yeah, but I'd rather initialize the counter to the first value that will be returned for clarity. If this changes to an ASN then I'll change it to pre-increment and document the -1.
	17 }

OLD	NEW