Issue 8400087: MIPS: Handlify CompileConstructStub and the remaining CallStubCompiler functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400087: MIPS: Handlify CompileConstructStub and the remaining CallStubCompiler functions. (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, Kevin Millikin (Chromium), ulan, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Handlify CompileConstructStub and the remaining CallStubCompiler functions. Port r9837 (38061af). Port r9834 (95ac04). Original commit message (r9834): Also, handlify functions for loading with interceptors and callbacks. Remove some unneeded code. Rename Foreign::address() because it confusingly shadows HeapObject::address() which does something quite different. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9844

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+382 lines, -931 lines)			Patch
M	src/mips/code-stubs-mips.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	4 chunks	+6 lines, -83 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	4 chunks	+6 lines, -31 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	7 chunks	+8 lines, -56 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	71 chunks	+362 lines, -750 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kisg

Please land together with the following changesets to fix test suite failures: http://codereview.chromium.org/8413073/ http://codereview.chromium.org/8417050/

9 years, 1 month ago (2011-10-30 08:42:32 UTC) #1

LGTM.  I will land it.

Expand Messages | Collapse Messages