Issue 8400076: Now gets preferred types from ProfileSyncService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400076: Now gets preferred types from ProfileSyncService. (Closed)

Created:
9 years, 1 month ago by Andrew T Wilson (Slow)

Modified:
9 years, 1 month ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Now gets preferred types from ProfileSyncService. SyncSetupFlow gets preferred types from PSS::GetPreferredTypes() rather than looking at the preferences directly. BUG=92625 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108031

Patch Set 1 #

Patch Set 2 : VSC++ is stoooooopid #

Patch Set 3 : Trunk merge. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -10 lines)			Patch
	M	chrome/browser/sync/sync_setup_flow.cc	View	1	2 chunks	+13 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

akalin

On 2011/10/29 01:18:00, Andrew T Wilson wrote: > Please take a look. LGTM

9 years, 1 month ago (2011-10-29 01:55:03 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/8400076/2001

9 years, 1 month ago (2011-10-31 17:09:41 UTC) #3

commit-bot: I haz the power

Try job failure for 8400076-2001 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=189 Step "update" is always ...

9 years, 1 month ago (2011-10-31 17:11:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/8400076/7001

9 years, 1 month ago (2011-10-31 17:24:54 UTC) #5

commit-bot: I haz the power

9 years, 1 month ago (2011-10-31 18:36:17 UTC) #6

Try job failure for 8400076-7001 (retry) (retry) on linux_rel for step
"ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages