Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: net/base/x509_certificate_win.cc

Issue 8400075: Fix the "certificate is not yet valid" error for server certificates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove the unrelated sslsock.c from the CL Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_certificate_win.cc
===================================================================
--- net/base/x509_certificate_win.cc (revision 107789)
+++ net/base/x509_certificate_win.cc (working copy)
@@ -541,6 +541,7 @@
valid_expiry_ = Time::FromFileTime(cert_handle_->pCertInfo->NotAfter);
fingerprint_ = CalculateFingerprint(cert_handle_);
+ chain_fingerprint_ = CalculateChainFingerprint();
const CRYPT_INTEGER_BLOB* serial = &cert_handle_->pCertInfo->SerialNumber;
scoped_array<uint8> serial_bytes(new uint8[serial->cbData]);
@@ -1018,6 +1019,11 @@
return sha1;
}
+SHA1Fingerprint X509Certificate::CalculateChainFingerprint() const {
+ // TODO(wtc): implement this.
agl 2011/10/28 23:45:47 It's not clear how this can be a TODO if the chang
Ryan Sleevi 2011/10/28 23:55:03 I fear once http://codereview.chromium.org/7324039
wtc 2011/10/29 01:32:03 Sorry about the confusion. I have implemented thi
+ return CalculateFingerprint(cert_handle_);
+}
+
// static
X509Certificate::OSCertHandle
X509Certificate::ReadOSCertHandleFromPickle(const Pickle& pickle,

Powered by Google App Engine
This is Rietveld 408576698